Stacking compliance

773pages on
this wiki
Add New Page
Talk0 Share
Browse all patches

Author Edit

Christian Marillat

Synopsis Edit

Change default stacking depth for docks.

Make fullscreen windows have a higher stacking depth than normal.

Patch Edit

--- sawfish-1.3.orig/lisp/sawfish/wm/windows.jl 27 Mar 2003 06:30:30 -0000      1.32
+++ sawfish-1.3/lisp/sawfish/wm/windows.jl      9 Aug 2005 12:20:52 -0000
@@ -99,7 +99,7 @@
   (defvar desktop-window-depth -4
     "The stacking depth of desktop windows.")

-  (defvar dock-window-depth 0
+  (defvar dock-window-depth 2
     "The stacking depth of dock windows.")


--- sawfish-1.3.orig/lisp/sawfish/wm/state/maximize.jl  2005-08-25 15:53:59.000000000 +0200
+++ sawfish-1.3/lisp/sawfish/wm/state/maximize.jl       2005-08-25 15:56:56.000000000 +0200
@@ -63,7 +63,8 @@
-         sawfish.wm.misc)
+         sawfish.wm.misc
+         sawfish.wm.stacking)

   (define-structure-alias maximize sawfish.wm.state.maximize)

@@ -93,6 +94,8 @@
   ;; called when a window is un-maximized, args (W #!optional DIRECTION)
   (defvar window-unmaximized-hook nil)

+  ;; value to add to window-depth when window becomes fullscreen
+  (defvar window-fullscreen-depth-offset 4)
 ;;; handling maximized state

@@ -500,9 +503,12 @@
                   (head-dims (current-head-dimensions w)))
               (save-unmaximized-geometry w)
               (window-put w 'unmaximized-type (window-type w))
+              (window-put w 'unmaximized-depth (window-depth w))
               (push-window-type w 'unframed 'sawfish.wm.state.maximize)
               (move-resize-window-to w (car head-offset) (cdr head-offset)
                                      (car head-dims) (cdr head-dims))
+              (set-window-depth w (+ window-fullscreen-depth-offset
+                       (window-depth w)))
               (raise-window* w)
               (window-put w 'maximized-fullscreen t)
               (window-put w 'maximized-vertically t)
@@ -513,6 +519,7 @@
                                 w (list '(maximized))))))
          ((and (not state) (window-maximized-fullscreen-p w))
+          (set-window-depth w (window-get w 'unmaximized-depth))
           (unmaximize-window w 'fullscreen))))
   (define (maximize-window-fullscreen-toggle w)

Community's reasons for inclusion or rejection Edit

No vote: no. There are no technical problems with this patch, but I think it's a drawback that you won't to be able to cycle through your windows when one is on fullscreen. (Which, btw, I can, so this patch is not currently applied in debian). --Sven Schoenung 16:08, 10 August 2007 (UTC)

Oh, and you might not notice popup-windows from other applications when a fullscreen window is running if this patch is applied (though I'm not sure about that) --Sven Schoenung 16:12, 10 August 2007 (UTC)

You're right, the patch is included in the debian source package but is not applied when building. I guess that argues against it. RodrigoGallardo

No vote: no. ok, so I reject it. Luis, you could delete this file from debian/patches dir, btw? Janek Kozicki 23:53, 16 January 2008 (UTC)

Ad blocker interference detected!

Wikia is a free-to-use site that makes money from advertising. We have a modified experience for viewers using ad blockers

Wikia is not accessible if you’ve made further modifications. Remove the custom ad blocker rule(s) and the page will load as expected.

Also on Fandom

Random Wiki