Wikia

Sawfish

Selfdefine xterm command

773pages on
this wiki
Talk0
Browse all patches

Author Edit

Dagfinn Ilmari Mannsåker

(Uploaded by Christopher Bratusek)

Synopsis Edit

taken from: http://bugzilla.gnome.org/show_bug.cgi?id=71895

This patch allows that the user-defined 'xterm' command is also used, then viewing the info file.

Patch Edit

--- lisp/sawfish/wm/commands/help.jl.orig	Tue Feb 19 02:59:24 2002
+++ lisp/sawfish/wm/commands/help.jl	Tue Feb 19 03:01:25 2002
@@ -29,12 +29,13 @@
 	  rep.system
 	  rep.regexp
 	  rep.io.files
-	  sawfish.wm.commands)
+	  sawfish.wm.commands
+	  sawfish.wm.commands.xterm)
 
   ;; Info
 
   (define (help-call-info document node)
-    (system (format nil "xterm -e info '%s' '%s' >/dev/null 2>&1 </dev/null &"
+    (xterm (format nil "info '%s' '%s'"
 		    document node)))
 
   (define (help-call-info-gnome document node)

Community's reasons for inclusion or rejection Edit

Patch submitters, please vote also! Yes, obviosuly your vote will be positive, but it's the place to give your explanation why this patch is good for all Sawfish users, and why it is correct - good reasons for inclusion.

When voting anonymously please write your name, so that it can be associated with your posts on the mailing list. If you are logged in you can sign yourself by typing four tilda characters: ~~~~.

  • Yes vote: yes. simple thing, info is still hardcoded, but better avoid requiring xterm when term is configurable already. GSR 21:29, 15 July 2008 (UTC)
  • Yes vote: yes. I think it's better to avoid hard-coded calls as much as it's possible. -Ferk(talk!) 02:43, 21 July 2008 (UTC)

Around Wikia's network

Random Wiki