Re-expose extra placement modes

773pages on
this wiki
Add New Page
Add New Page Talk0
Browse all patches

Author Edit

Andrea Vettorello

Synopsis Edit

Brings back "stagger" and "off-center" placement modes.

Patch testing Edit

  1. Copy/paste the patch listed below into some file, eg. TEST.diff.
  2. If you don't have sawfish sources yet, have one, as described get it from GIT repo.
  3. Go into the directory where sawfish sources reside, eg. cd sawfish
  4. Test if the patch applies cleanly with this command:
    patch -p1 --ignore-whitespace --dry-run < TEST.diff
    in case of problems try also: -p0 or -p2
  5. If it applies cleanly, then remove the --dry-run from above command and run it again, otherwise ask on the mailing list.
  6. Compile sawfish: ./ && make
  7. Install it for testing, but it depends on your linux distribution.
    1. It is always better to install sawfish as your distribution package, but it is different for each distribution.
    2. So you may try make install, which will install sawifish in /usr/local/share/sawfish/ (if you have write access). But then make sure that you run the correct version and delete it from that directory afterwards, to avoid any conflicts.
  8. Se also

PS: edit this template if you feel that those instructions can be improved.

Patch Edit

Index: lisp/sawfish/wm/placement/stagger.jl
--- lisp/sawfish/wm/placement/stagger.jl	(revision 4311)
+++ lisp/sawfish/wm/placement/stagger.jl	(working copy)
@@ -51,4 +51,4 @@
 	  (move-window-to w last-x last-y)))))
-  (define-placement-mode 'stagger place-window-stagger))
+  (define-placement-mode 'stagger place-window-stagger #:for-normal t))
Index: lisp/sawfish/wm/placement/off-center.jl
--- lisp/sawfish/wm/placement/off-center.jl	(revision 4311)
+++ lisp/sawfish/wm/placement/off-center.jl	(working copy)
@@ -123,4 +123,4 @@
 	      (loop (1+ index))))))))
-  (define-placement-mode 'off-center place-window-off-center))
+  (define-placement-mode 'off-center place-window-off-center #:for-normal t))
Index: lisp/sawfish/wm/autoload.jl
--- lisp/sawfish/wm/autoload.jl	(revision 4311)
+++ lisp/sawfish/wm/autoload.jl	(working copy)
@@ -150,8 +150,8 @@
 (autoload-command (quote describe-key-to-screen) (quote sawfish.wm.util.keymap))
 (autoload-command (quote quote-event) (quote sawfish.wm.util.keymap))
 (autoload-placement-mode 'top-left ' #:for-normal t)
-(autoload-placement-mode 'stagger 'sawfish.wm.placement.stagger)
-(autoload-placement-mode 'off-center '
+(autoload-placement-mode 'stagger 'sawfish.wm.placement.stagger #:for-normal t)
+(autoload-placement-mode 'off-center ' #:for-normal t)
 (autoload-command (quote set-viewport-linear) (quote "viewport-linear") #:type (backquote (and (labelled (backquote-unquote (_ "Index:")) (number 0)))) #:class 'default)
 (autoload-command (quote set-window-viewport-linear) (quote "viewport-linear") #:type (backquote (and (labelled (backquote-unquote (_ "Index:")) (number 0)))) #:class 'default)
 (autoload-command 'set-viewport-linear:1 'sawfish.wm.commands.viewport-linear #:class 'default)

Community's reasons for inclusion or rejection Edit

Patch submitters, please vote also! Yes, obviously your vote will be positive, but it's the place to give your explanation why this patch is good for all Sawfish users, and why it is correct - good reasons for inclusion.

When voting anonymously please write your name, so that it can be associated with your posts on the mailing list. If you are logged in you can sign yourself by typing four tilda characters: ~~~~.

  • Please vote with: Yes vote: yes., No vote: no., Try vote: let's try in experimental., Wtf vote: pondering. or Suspend wait for next release.
  • Yes vote: yes. Patch seems harmless, but I didn't tested both modes enough to say if they are safe to be included on next stable version, and I ignore the reason they were removed. - Aav 12:31, 16 December 2008 (UTC)

Also on Fandom

Random Wiki