From Sawfish

Browse all patches

[–] Category:Patches [+] Category:Accepted for 1.3.1 [+] Category:Accepted for 1.3.2 [+] Category:Accepted for 1.3.3 [+] Category:Accepted patches [+] Category:Rejected patches [+] Category:Submitted patches Missing patches

[edit] Author

Andrea Vettorello

[edit] Synopsis

I can't find in the EWMH specs how should be managed a window with _NET_WM_WINDOW_TYPE_TOOLBAR property enabled, but in this email http://mail.gnome.org/archives/wm-spec-list/2002-July/msg00002.html is stated that a toolbar should be decorated by the toolkit not the window manager.

[edit] Patch testing

1. Copy/paste the patch listed below into some file, eg. TEST.diff.
2. If you don't have sawfish sources yet, then make a fresh checkout:

   svn checkout svn://svn.gnome.org/svn/sawfish/trunk

3. Go into the directory where sawfish sources reside, eg. cd trunk
4. Test if the patch applies cleanly with this command:

   patch -p1 --ignore-whitespace --dry-run < TEST.diff

   in case of problems try also: -p0 or -p2
5. If it applies cleanly, then remove the --dry-run from above command and run it again, otherwise ask on the mailing list.
6. Compile sawifsh with those instructions or with those: autogen.sh ; make
7. Install it for testing, but it depends on your linux distribution.
   1. It is always better to install sawfish as your distribution package, but it is different for each distribution.
   2. So you may try make install, which will install sawifish in /usr/local/share/sawfish/ (if you have write access). But then make sure that you run the correct version and delete it from that directory afterwards, to avoid any conflicts.

PS: edit this template if you feel that those instructions can be improved.

[edit] Patch

--- sawfish-1.3.3/lisp/sawfish/wm/frames.jl	2007-07-29 11:45:04.000000000 +0200
+++ sawfish-1.3.3-local/lisp/sawfish/wm/frames.jl	2008-04-05 16:51:51.610555185 +0200
@@ -156,10 +156,10 @@
       (dock . icon)
       (utility . default)
       (shaded-utility . shaded-transient)
-      (toolbar . utility)
-      (shaded-toolbar . shaded-utility)
-      (menu . utility)
-      (shaded-menu . shaded-utility)
+      (toolbar . unframed)
+;;    (shaded-toolbar . shaded-utility)
+      (menu . unframed)
+;;    (shaded-menu . shaded-utility)
       (splash . unframed))
     "Frame type fallbacks.")
 

[edit] Community's reasons for inclusion or rejection

Patch submitters, please vote also! Yes, obviosuly your vote will be positive, but it's the place to give your explanation why this patch is good for all Sawfish users, and why it is correct - good reasons for inclusion.

When voting anonymously please write your name, so that it can be associated with your posts on the mailing list. If you are logged in you can sign yourself by typing four tilda characters: ~~~~.

• vote: yes. As the author I would say yes as it fixes at least one application (Screenlets), but don't know if it breaks something else. - Aav 15:14, 5 April 2008 (UTC)

• vote: yes. Hmm, yeah I also say yes. Since It solves the problem I've found, furthermore I didn't discover problems with other apps. - Christopher Bratusek 19:27:45, 10 April 2008 (UTC +0200)

• vote: yes. With the menu type windows also unframed, this fixes GNUstep's menus as well, and I haven't run into any problems. - Harald van Dijk 21:05, 13 May 2008 (CEST)