Wikia

Sawfish

Another cleanup

773pages on
this wiki
Talk0
Browse all patches

Author Edit

Christopher Bratusek

Synopsis Edit

The window-plist and window-remprop patch by Teika and Timo broke building with "-Wall -ansi -pedantic".

Make it work again. (also requires librep r2925 - or newer).

Please test, if the new functions work correctly!

Patch testing Edit

  1. Copy/paste the patch listed below into some file, eg. TEST.diff.
  2. If you don't have sawfish sources yet, have one, as described get it from GIT repo.
  3. Go into the directory where sawfish sources reside, eg. cd sawfish
  4. Test if the patch applies cleanly with this command:
    patch -p1 --ignore-whitespace --dry-run < TEST.diff
    in case of problems try also: -p0 or -p2
  5. If it applies cleanly, then remove the --dry-run from above command and run it again, otherwise ask on the mailing list.
  6. Compile sawfish: ./autogen.sh && make
  7. Install it for testing, but it depends on your linux distribution.
    1. It is always better to install sawfish as your distribution package, but it is different for each distribution.
    2. So you may try make install, which will install sawifish in /usr/local/share/sawfish/ (if you have write access). But then make sure that you run the correct version and delete it from that directory afterwards, to avoid any conflicts.
  8. Se also

PS: edit this template if you feel that those instructions can be improved.

Patch Edit

Index: src/windows.c
===================================================================
--- src/windows.c	(Revision 4269)
+++ src/windows.c	(Arbeitskopie)
@@ -80,15 +80,15 @@
 
 static repv gravity_map[StaticGravity+1];
 
-// In sawfish-1.3.3, the only callback used is keymap_prop_change. 
+static struct prop_handler *prop_handlers;
+
+/* In sawfish-1.3.3, the only callback used is keymap_prop_change. */ 
 struct prop_handler {
     struct prop_handler *next;
     repv prop;
     void (*callback) (Lisp_Window *w, repv prop, repv old, repv new);
 };
 
-static struct prop_handler *prop_handlers;
-
 �
 /* utilities */
 

Community's reasons for inclusion or rejection Edit

Patch submitters, please vote also! Yes, obviosuly your vote will be positive, but it's the place to give your explanation why this patch is good for all Sawfish users, and why it is correct - good reasons for inclusion.

When voting anonymously please write your name, so that it can be associated with your posts on the mailing list. If you are logged in you can sign yourself by typing four tilda characters: ~~~~.

  • Please vote with: Yes vote: yes., No vote: no., Try vote: let's try in experimental., Wtf vote: pondering. or Suspend wait for next release.
  • Wtf vote: pondering. You lost me here. The C99/C++ style comment won't pass with -ansi, equivalent to -std=c89, but why would the definition order matter? Tkorvola 18:03, 8 August 2008 (UTC)
try it out the definition order matters. dunno why, but it is like that Flashrider [Christopher Bratusek] 18:27, 8 August 2008 (UTC)
  • Yes vote: yes. I'm all in favor of keeping sawfish clean compiling. This will help us in the future. Janek Kozicki 07:54, 9 August 2008 (UTC)
  • Yes vote: yes. No reason for rejecting, assuring a clean compile also helps keeping a clean coding style -Ferk(talk!) 13:13, 9 August 2008 (UTC)
  • Try vote: let's try in experimental. I'm running it currently, I think that it can go to experimental. OK, added to experimental. Janek Kozicki 16:21, 17 September 2008 (UTC)

Around Wikia's network

Random Wiki